I reviewed Pirate Software's code. Oh boy...

Summary

In this video, the creator critically reviews the coding practices of Thor, also known as Pirate Software, a popular YouTuber and game developer. The review highlights issues such as the use of magic numbers, poor variable naming, and improper data types in his code. The reviewer emphasizes that these mistakes, alongside excessive comments and inefficient data structures, point to a lack of professionalism in Thor's coding practices. Despite Thor's claims of being an experienced game developer, the video argues that his code reflects a lower skill level, akin to that of an intern, and offers suggestions for improvement.

Takeaways

• 😀 Thor, a popular streamer and YouTuber, has misrepresented the 'Stop Killing Games' movement, which aims to protect consumer rights by ensuring games continue to function even after developers stop supporting them.
• 😀 The 'Stop Killing Games' initiative, launched by Ross Scott, advocates for publishers to provide an end-of-life plan for games, allowing players continued access even after online services are shut down.
• 😀 Thor has been criticized for claiming a 20-year career in game development, but his actual coding practices and streams have raised doubts about his expertise and the accuracy of his claims.
• 😀 Despite his claims of being an experienced game developer, Thor's live coding streams show minimal actual coding, with the majority of time spent on non-development-related activities like checking subscriptions and watching videos.
• 😀 Thor’s coding practices are criticized for being sloppy, with 'magic numbers' and unexpressive variable names making the code hard to understand and maintain.
• 😀 One example criticized in Thor’s code is the use of raw numbers without any descriptive context, making it unclear what they represent, leading to confusion and potential bugs.
• 😀 The absence of meaningful comments and the reliance on arbitrary numbers in the code further indicate poor coding practices and a lack of proper documentation.
• 😀 Thor’s misuse of data types in certain variables, such as using integers instead of booleans, is pointed out as a clear misunderstanding of how to properly represent information in code.
• 😀 The code reviewed also shows a lack of structure, such as using flat arrays for complex data like storylines, when better alternatives like nested structures or configuration files could be used.
• 😀 Thor's game development practices are presented as subpar, with examples of extremely inefficient and error-prone coding that would not meet industry standards or be acceptable in a production environment.

Q & A

Who is Thor, and why is he being discussed in this video?

Thor, also known as Pirate Software, is a popular YouTuber and streamer. He is being discussed due to his stance against the 'Stop Killing Games' movement and his alleged misrepresentation of the initiative. The video aims to critique his coding practices and claims of being a 20-year veteran game developer.

What is the 'Stop Killing Games' initiative, and who started it?

'Stop Killing Games' is an advocacy movement aimed at preventing game publishers from revoking access to games after their servers are shut down. It was launched by Ross Scott, who seeks to protect consumers from being sold games that can no longer be accessed once online services are discontinued.

What is the core message behind the 'Stop Killing Games' movement?

The core message of 'Stop Killing Games' is to advocate for a planned 'end of life' process for games. This would ensure that consumers can continue to play the games they have purchased even after a publisher stops supporting them.

Why is the speaker critical of Thor's views on the 'Stop Killing Games' movement?

The speaker criticizes Thor for misrepresenting the movement and his stance on it, accusing him of lying about his experience or playing it off as something it is not. The speaker disagrees with Thor’s approach and believes he has mischaracterized the initiative.

What is the focus of the speaker's critique about Thor's code?

The speaker critiques Thor’s coding practices, highlighting poor coding practices like using magic numbers, unexpressive variable names, and incorrect data types. The speaker questions whether Thor, who claims to have 20 years of experience, truly possesses the skills he claims.

What are 'magic numbers' in coding, and why are they problematic?

Magic numbers are numerical values used in code without explanation or context. They are problematic because they make the code unclear and difficult to understand. Without proper labeling or description, it's hard to know what these numbers represent, making the code hard to maintain and debug.

What is the issue with Thor's use of 'true' or 'false' in his code?

The use of 'true' or 'false' without context is problematic because it is unexpressive. The code should indicate what those values represent, instead of relying on ambiguous boolean values, which reduces the clarity and maintainability of the code.

What is 'strong typing,' and how does it improve code?

Strong typing involves using more expressive types or aliases for variables, which helps clarify their meaning. Instead of using arbitrary numbers or booleans, it’s better to define specific types (e.g., horsepower, transmission type), making the code more readable and maintainable.

Why is Thor's use of 'alarm' variables in his code problematic?

Thor's use of 'alarm' variables is problematic because the names do not indicate their purpose or context. Without clear naming, it’s difficult for other developers to understand what these variables represent, leading to confusion and potential bugs.

What are the issues with Thor’s use of arrays for event timelines?

Thor uses a flat, one-dimensional array with random numbers as indices to represent events in a game. This practice makes the code hard to understand and maintain. A better approach would be to use structured data, like a nested structure or a configuration file, which would be easier to modify and understand.